Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Recognise walrus operator #3126

Merged
merged 1 commit into from Oct 5, 2021

Conversation

hoonweiting
Copy link
Contributor

Python 3.8 introduced the assignment expression operator, better known as the walrus operator. However, I'm not sure if ...|!=|:=|... is preferred over ...|[!:]=|....

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'll merge this after GH Actions come back online.

Thank you @hoonweiting!

However, I'm not sure if ...|!=|:=|... is preferred over ...|[!:]=|....

Both are fine.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +1 B (+0.1%).

file master pull size diff % diff
components/prism-python.min.js 1.06 KB 1.06 KB +1 B +0.1%

Generated by 🚫 dangerJS against 5bcbc7c

@RunDevelopment RunDevelopment merged commit 18bd101 into PrismJS:master Oct 5, 2021
@hoonweiting hoonweiting deleted the python-walrus branch October 5, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants