Python: Add match and case (soft) keywords
#3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Oct 7, 2021
There was a problem hiding this comment.
Thank you for the PR @hoonweiting!
One minor nit, otherwise gtg.
|
|
|
Thank you for contributing @hoonweiting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.10 (just released on Monday!) introduces structural pattern matching, aka switch-case statements, except that in Python it's match-case. It's currently a soft keyword, together with
_which kinda acts likedefaultin JavaScript. This PR addsmatch,case, and_(if:comes right after it) as keywords.*can be used as a wildcard, and_can also be used within lists and dictionaries to represent the idea ofdefault. But I'm not sure if I should try to match_when it is used in such situations? I feel that there'll be quite a few cases to consider (even if we only consider code that follows the style guide), and I don't know how Prism normally deals with this.