Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Improved readability #3177

Merged
merged 4 commits into from Nov 8, 2021

Conversation

RunDevelopment
Copy link
Member

Fixes #3175.

image

image

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

No JS Changes

Generated by 🚫 dangerJS against b3b9ea7

@not-my-profile
Copy link

Thanks, that is definitely better! However I still find the text below the headings to be a bit hard to read. Probably mainly due to the narrow font.

@RunDevelopment
Copy link
Member Author

I agree. It's more readable with a larger font size.

image

It's not perfectly readable (it's hard with such a high-contrast background) but I think it's okay-ish.

@not-my-profile
Copy link

not-my-profile commented Nov 6, 2021

How about adding a transparent overlay to make the background less distracting? See #3179.

@RunDevelopment
Copy link
Member Author

Very good idea @not-my-profile!

image

@not-my-profile
Copy link

LGTM!

@RunDevelopment RunDevelopment merged commit 4433d7f into PrismJS:master Nov 8, 2021
@RunDevelopment RunDevelopment deleted the issue3175 branch November 8, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prismjs.com has poor readability
2 participants