Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSIS: Update Regex pattern for variables #3266

Merged
merged 7 commits into from Dec 4, 2021
Merged

NSIS: Update Regex pattern for variables #3266

merged 7 commits into from Dec 4, 2021

Conversation

idleberg
Copy link
Contributor

@idleberg idleberg commented Dec 4, 2021 •
edited

Unless at the beginning of a variable name, variables in NSIS may contain the .-character (see example).

Changes:

  • update Regex pattern for variables to support dots
  • add test for the above

@github-actions
Copy link

github-actions bot commented Dec 4, 2021 •
edited

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +4 B (+0.2%).

file master pull size diff % diff
components/prism-nsis.min.js 2.02 KB 2.02 KB +4 B +0.2%

Generated by 🚫 dangerJS against b352154

@idleberg idleberg mentioned this pull request Dec 4, 2021
Merged
RunDevelopment
RunDevelopment requested changes Dec 4, 2021
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @idleberg!

components/prism-nsis.js Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

Please also resolve the merge conflict.

@RunDevelopment RunDevelopment merged commit adcc878 into PrismJS:master Dec 4, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @idleberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment requested changes

Assignees
No one assigned
Labels
enhancement language-definitions needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idleberg @RunDevelopment