Adding UO Razor Script to available languages #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +1.22 KB (+48.2%).
|
RunDevelopment
requested changes
Jan 26, 2022
There was a problem hiding this comment.
Thank you for the PR @jaseowns!
I left you a few comments.
Regarding the order of tokens: Prism supports greedy tokens. Strings and comments are typically greedy, so e.g. " // foo " is a string and // " foo " is a comment despite both containing the syntax of the other. Please make all comment and string greedy (greedy: true).
Also, please move all (the new) greedy tokens to the top of the grammar. This doesn't change the language, but it makes it faster.
RunDevelopment
approved these changes
Jan 28, 2022
|
Thank you for contributing @jaseowns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I play Ultima Online and we use a program called Razor to help script and hotkey certain actions. I'm making a website related to these scripts and would love to be able to use the react-syntax-highlighter importing this language file from Prism.
This is my first time submitting anything like this to open source so let me know if I need to change anything!
Thanks,
Jaseowns