Command line: Increased prompt opacity #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree with this change, also makes it consistent with the opacity of the output lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing switching between themes on the Command line plugin page, I noticed that the prompt is very hard to read for some themes. This is because the prompt only has an opacity of 40%. While this may have been in line with the previous fixed color (see #3326), I think it's too transparent.
This PR changes the opacity to 70%. This ensures that the prompt is readable in all themes. (Except Funky, but Funky has problems with Command Line in general, so let's ignore it.)
@at055612, this might interest you.