Keep Markup: Restore original nodes instead of clones #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golmote
commented
Mar 5, 2022
|
@RunDevelopment PR updated as per your comments. |
RunDevelopment
approved these changes
Mar 5, 2022
LeaVerou
approved these changes
Mar 5, 2022
|
Thank you so much @Golmote!! Can't wait to use this in combination with Mavo to make live demos with code that is editable through selects, ranges etc without having to employ crazy hacks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the Keep Markup plugin used to clone the markup nodes. This is problematic when you have a reference to a markup node before highlighting: it would be lost after highlighting.
These changes make it so that the plugin keeps the actual original markup nodes in the highlighted output.