Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erlang: Add begin keyword #3387

Merged
merged 1 commit into from Mar 13, 2022
Merged

Conversation

hoonweiting
Copy link
Contributor

Adding the begin keyword in Erlang.

cond and let are also reserved words in Erlang, but they're not currently being used. I'm not sure if they should be added, I think not, but I'm not sure!

@github-actions
Copy link

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +4 B (+0.9%).

file master pull size diff % diff
components/prism-erlang.min.js 452 B 456 B +4 B +0.9%

Generated by 🚫 dangerJS against 8312a7a

@RunDevelopment
Copy link
Member

Thank you for the PR!

cond and let are also reserved words in Erlang, but they're not currently being used.

Then we'll just wait. Languages typically have a few reserved words for future use. Frankly, it's up to us whether we want to highlight them. Since they are reserved, any usage of those unused reserved keywords is invalid syntax, and Prism is allowed to highlight invalid syntax as whatever we want.

That being said, I typically opt not to include revered-but-not-used keywords, simply because they (slightly) increase the file size of our languages.

@hoonweiting hoonweiting deleted the erlang-keywords branch March 13, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants