Use terser #3407
Merged
Use terser #3407
+280
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS File Size Changes (gzipped)A total of 108 files have changed, with a combined diff of +288 B (+0.3%).
|
|
I had to disable unsafe transformations again because of a bug in the v8 version shipped in NodeJS 10.x. I even reported and helped fix this bug in terser a while ago, but it seems that there was a regression. It's a shame, but it's not worth the hassle now. Since this is a NodeJS 10.x specific bug, we might as well enable the transformation after dropping support for that version of Node. |
JaKXz
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces UglifyJS 3 with Terser (5.x).
Since we want to transition to ES6 in v2, we'll need a minifier that supports ES6. We currently use UglifyJS 3, but that is a pure ES5 minifier. Since transpiling our code into ES5 would add complexity and result in worse file sizes, I think the easiest solution is to just minify our ES6(+?) code.