Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang (never calls onPostResponse or onError) #27

Open
singpolyma opened this issue Sep 18, 2023 · 5 comments
Open

Hang (never calls onPostResponse or onError) #27

singpolyma opened this issue Sep 18, 2023 · 5 comments

Comments

@singpolyma
Copy link

Describe the bug
Trying to parse with URL https://www2.hm.com/en_ca/productpage.1101542003.html I never get a call to either of onPostResponse or onError and my app hangs.

Expected behavior
Should always call one or the other.

@Priyansh-Kedia
Copy link
Owner

Hello @singpolyma
What configuration did you use for OGP, I tried the same link and got a successful response

Thanks

@Priyansh-Kedia
Copy link
Owner

Hello @singpolyma
First, if you increase the max body size and timeout you should get a response (check README to see how they are specified).

In case you do not want to change the values and get error message thrown, you need showNullOnEmpty to be true in that case as the empty response is taken to be null

Let me know how it works out

Thanks

@singpolyma
Copy link
Author

yes, setting showNullOnEmpty to true fixes it. Is it intended that a null result with that set to false will simply call neither callback?

@Priyansh-Kedia
Copy link
Owner

No this is not ideal.

I shall fix this and release an update.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants