Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize JSON instructions into struct #36

Open
1ec5 opened this issue Aug 26, 2017 · 0 comments
Open

Deserialize JSON instructions into struct #36

1ec5 opened this issue Aug 26, 2017 · 0 comments

Comments

@1ec5
Copy link
Member

1ec5 commented Aug 26, 2017

OSRMInstructionFormatter should immediately deserialize the JSON instructions into a strongly typed struct. This change would sharply reduce the number of implicitly unwrapped optionals (!) that could cause crashes and clean up the code significantly. Once we migrate to Swift 4, we’ll be able to take advantage of the Codable protocol to reduce the code size even further.

/cc @frederoni @freenerd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant