Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade rollup plugins and resolve preventAssignment default setting warning #526

Closed
1 of 5 tasks
thescientist13 opened this issue Apr 10, 2021 · 1 comment
Closed
1 of 5 tasks

upgrade rollup plugins and resolve preventAssignment default setting warning #526

thescientist13 opened this issue Apr 10, 2021 · 1 comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 10, 2021 •
edited

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

In newer installations of Greenwood, getting this message from @rollup/plugin-replace

@rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.

Details

We should:

  1. update our versions of Rollup and across our packages.
  2. Add that setting where we are using it so that warning goes away
@thescientist13 thescientist13 added good first issue Good for newcomers chore unit testing, maintenance, etc CLI labels Apr 10, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 10, 2021
@thescientist13 thescientist13 mentioned this issue Apr 11, 2021
Closed
53 tasks
@thescientist13 thescientist13 removed this from the 1.0 milestone Mar 15, 2022
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) and removed chore unit testing, maintenance, etc labels Mar 15, 2022
@thescientist13
Copy link
Member Author

we are already tracking #1087 , so this is kind of a dupe now.

@thescientist13 thescientist13 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thescientist13