Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade project codebase to ESM #532

Closed
1 of 5 tasks
thescientist13 opened this issue Apr 11, 2021 · 1 comment · Fixed by #707, #814, #815, #817 or #818
Closed
1 of 5 tasks

Upgrade project codebase to ESM #532

thescientist13 opened this issue Apr 11, 2021 · 1 comment · Fixed by #707, #814, #815, #817 or #818
Assignees
@thescientist13
Labels
alpha.0 chore unit testing, maintenance, etc question Further information is requested v0.20.0
Projects
6 - Theme Packs and SSR R&D + ESM Upg... 7 - SSR and External Data Sources
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 11, 2021 •
edited

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Currently the base version of NodeJS is v12, but is also tested against v14. It would be good to cutover to v14 for 1.0 release and re-write all our packages/ code to use ESM.

Additionally, Mocha v7 supports import too.

Details

This will also allows us to "merge" these two versions of the same common code.
@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Apr 11, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 11, 2021
This was referenced Apr 11, 2021
Closed
Closed
@thescientist13 thescientist13 added the question Further information is requested label Apr 23, 2021
@thescientist13 thescientist13 mentioned this issue Jun 12, 2021
Open
12 tasks
@thescientist13
Copy link
Member Author

Make sure we checkin / checkup on Stackblitz support whenever we start on this
#639 (comment)

@thescientist13 thescientist13 mentioned this issue Aug 26, 2021
Open
5 tasks
@thescientist13 thescientist13 changed the title Upgrade to Node v14 default (and convert to ESM?) Upgrade project codebase to ESM Aug 29, 2021
@thescientist13 thescientist13 self-assigned this Aug 29, 2021
This was referenced Aug 31, 2021
Closed
Merged
@thescientist13 thescientist13 pinned this issue Sep 7, 2021
@thescientist13 thescientist13 linked a pull request Dec 3, 2021 that will close this issue
bug/issue 532 esm upgrade with fix for windows #814
Merged
This was referenced Dec 4, 2021
Merged
Merged
@thescientist13 thescientist13 linked a pull request Dec 8, 2021 that will close this issue
restore support for extending babel configuration #817
Merged
@thescientist13 thescientist13 mentioned this issue Dec 8, 2021
Merged
@thescientist13 thescientist13 linked a pull request Dec 8, 2021 that will close this issue
switch to c8 for ESM code coverage #818
Merged
@thescientist13 thescientist13 moved this from IN PROGRESS to IN REVIEW in 7 - SSR and External Data Sources Dec 8, 2021
This was referenced Dec 18, 2021
Open
Merged
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 7 - SSR and External Data Sources Dec 18, 2021
@thescientist13 thescientist13 mentioned this issue Dec 28, 2021
Merged
@thescientist13 thescientist13 linked a pull request Dec 28, 2021 that will close this issue
missed migrating all website file from CJS to ESM #837
Merged
@thescientist13 thescientist13 unpinned this issue Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.0 chore unit testing, maintenance, etc question Further information is requested v0.20.0
Projects
No open projects
6 - Theme Packs and SSR R&D + ESM Upg...
IN PROGRESS
7 - SSR and External Data Sources
DONE
Milestone
1.0
1 participant
@thescientist13