Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-fetch package is not being correctly tracked as a dependency #807

Closed
1 of 5 tasks
thescientist13 opened this issue Nov 29, 2021 · 0 comments · Fixed by #808
Closed
1 of 5 tasks

node-fetch package is not being correctly tracked as a dependency #807

thescientist13 opened this issue Nov 29, 2021 · 0 comments · Fixed by #808
Assignees
Labels
bug Something isn't working chore unit testing, maintenance, etc CLI v0.19.4
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Just noticed that although node-fetch is being used in a couple places in the project, it's not actually defined in any of our package.json's! 😱

Screen Shot 2021-11-29 at 11 06 53 AM

Details

Basically, if you look at the output from Yarn, it looks like we've gotten luck that it has come in through other dependencies, but we should really track it since those deps could change at any time.

% yarn why node-fetch
yarn why v1.22.5
[1/4] 🤔  Why do we have the module "node-fetch"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "node-fetch@2.6.1"
info Reasons this module exists
   - "_project_#@greenwood#cli#puppeteer" depends on it
   - Hoisted from "_project_#@greenwood#cli#puppeteer#node-fetch"
   - Hoisted from "_project_#lerna#@lerna#version#@lerna#gitlab-client#node-fetch"
   - Hoisted from "_project_#@greenwood#plugin-graphql#apollo-server#apollo-server-core#apollo-server-env#node-fetch"
   - Hoisted from "_project_#@greenwood#plugin-graphql#apollo-server#apollo-server-core#@apollographql#apollo-tools#apollo-env#node-fetch"
   - Hoisted from "_project_#lerna#@lerna#version#@lerna#github-client#@octokit#rest#@octokit#request#node-fetch"
info Disk size without dependencies: "180KB"
info Disk size with unique dependencies: "180KB"
info Disk size with transitive dependencies: "180KB"
info Number of shared dependencies: 0
✨  Done in 0.97s.

Unfortunately, NodeJS doesn't have an implementation of the Fetch API natively (nodejs/node#19393) 😢

@thescientist13 thescientist13 added bug Something isn't working chore unit testing, maintenance, etc CLI labels Nov 29, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 29, 2021
@thescientist13 thescientist13 self-assigned this Nov 29, 2021
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 7 - SSR and External Data Sources Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore unit testing, maintenance, etc CLI v0.19.4
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant