Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: need to add proper handling for monorepos #54

Open
regevbr opened this issue Apr 4, 2020 · 1 comment
Open

bug: need to add proper handling for monorepos #54

regevbr opened this issue Apr 4, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@regevbr
Copy link
Contributor

regevbr commented Apr 4, 2020

Currently, we are assuming the package files are located at the git repo listed in package.json, but in mono repos (like jest) that is not the case.
Need to add logic to realize that is the case and handle it properly.
initial solution that comes to mind is to check the name in the root packge.json file and if it does not match, iterate the folders for the proper directory
In case that the repo is handled by lerna (lerna.json exists) It seems that the ci configs are still at the root directory so maybe this issue is not relevant at all...

@regevbr regevbr added the bug Something isn't working label Apr 4, 2020
@regevbr
Copy link
Contributor Author

regevbr commented Apr 18, 2020

Actually, it seems that you one can specify the directory in the repo when using monorepos. I have already added that metadata to the package info DTO.
I noticed that not all packages actually define it.
I think that the issue here is not the ci configs, which will (I think) will always reside at the root directory, but that maybe the test scripts might be per package and I believe we should handle it in those cases.

Another thing is that monorepos that use yarn2 have a configuration in package.json to denote the sub packages, so we need to handle those as well

@stale stale bot added the wontfix This will not be worked on label Jun 18, 2020
@PruvoNet PruvoNet deleted a comment from stale bot Jun 18, 2020
@stale stale bot removed the wontfix This will not be worked on label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant