Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move to yarn 2 #56 #60

Closed
wants to merge 3 commits into from
Closed

chore: move to yarn 2 #56 #60

wants to merge 3 commits into from

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Apr 14, 2020 •
edited

fix #56

@regevbr regevbr added the chore Make the code better label Apr 14, 2020
@regevbr regevbr requested a review from ynahmany April 14, 2020 01:01
@regevbr regevbr self-assigned this Apr 14, 2020
@regevbr
Copy link
Contributor Author

regevbr commented Apr 14, 2020 •
edited

@ynahmany please notice that in order to support zero installs I committed yarns cache

@regevbr
Copy link
Contributor Author

regevbr commented Apr 14, 2020 •
edited

There are a couple of issues that prevents us from moving to yarn 2 for now:

Snyk doesn't work with yarn 2

snyk/nodejs-lockfile-parser#56

Also, we need to wait for release newer than rc32 as a patch of typescript is required and not released yet

@codecov
Copy link

codecov bot commented Apr 16, 2020 •
edited

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          79       79           
  Lines        1519     1519           
  Branches      189      189           
=======================================
  Hits         1477     1477           
  Misses         42       42
Flag Coverage Δ
#unittest 97.23% <ø> (ø)

@regevbr regevbr changed the base branch from #12 to master April 20, 2020 12:10
@stale stale bot added the wontfix This will not be worked on label Jun 26, 2020
@PruvoNet PruvoNet deleted a comment from stale bot Jun 26, 2020
@stale stale bot removed the wontfix This will not be worked on label Jun 26, 2020
@ynahmany ynahmany closed this Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ynahmany ynahmany Awaiting requested review from ynahmany

Assignees

@regevbr regevbr

Labels
chore Make the code better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: move to yarn 2
2 participants
@regevbr @ynahmany