Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use better typings of consola once they are fixed #63

Closed
regevbr opened this issue Apr 17, 2020 · 1 comment · Fixed by #73
Closed

chore: use better typings of consola once they are fixed #63

regevbr opened this issue Apr 17, 2020 · 1 comment · Fixed by #73
Assignees
@regevbr
Labels
chore Make the code better

Comments

@regevbr
Copy link
Contributor

regevbr commented Apr 17, 2020

Currently I had to patch the typings as they are incomplete
I created a PR to fix them - unjs/consola#94
Once it is merged, we need to use the typings from there
@regevbr regevbr added feature Add new feature chore Make the code better and removed feature Add new feature labels Apr 17, 2020
@regevbr regevbr self-assigned this Apr 17, 2020
@regevbr regevbr changed the title chore: use better typings of console once they are fixed chore: use better typings of consola once they are fixed May 7, 2020
@regevbr
Copy link
Contributor Author

regevbr commented May 7, 2020

We now need to wait for unjs/consola#96 to get merged as the previous PR was faulty

regevbr added a commit that referenced this issue May 7, 2020
@regevbr
chore: use better typings of consola once they are fixed #63
0163e31
regevbr added a commit that referenced this issue May 7, 2020
@regevbr
chore: use better typings of consola once they are fixed #63
9d73f98
regevbr added a commit that referenced this issue May 7, 2020
@regevbr
chore: use better typings of consola once they are fixed #63
f88d4b9
regevbr added a commit that referenced this issue May 7, 2020
@regevbr
chore: use better typings of consola once they are fixed #63
9777ab8
regevbr added a commit that referenced this issue May 8, 2020
@regevbr
chore: use better typings of consola once they are fixed #63
2a0fc3b
@regevbr regevbr mentioned this issue May 8, 2020
Merged
regevbr added a commit that referenced this issue May 8, 2020
@regevbr
chore: use better typings of consola once they are fixed #63 (#73)
56bedde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regevbr regevbr

Labels
chore Make the code better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use better typings of consola once they are fixed #63 PruvoNet/node-upgrade-checker
1 participant
@regevbr