Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: not all packages have a test/build script #65

Open
regevbr opened this issue Apr 18, 2020 · 2 comments
Open

bug: not all packages have a test/build script #65

regevbr opened this issue Apr 18, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@regevbr
Copy link
Contributor

regevbr commented Apr 18, 2020

We currently assume that there is an npm script called "test", but that is not always the case (see https://github.com/yarnpkg/berry/blob/master/package.json for example)
We need to think of a way to realize the test script if one doesn't exist (and to verify its existence before hand)

@regevbr regevbr added the bug Something isn't working label Apr 18, 2020
@regevbr
Copy link
Contributor Author

regevbr commented Apr 18, 2020

Maybe we can show the user the list of available scripts and let him choose which one to use.
In that case I think we need to add this as configuration per package, and also persist the script name in the cache

@regevbr
Copy link
Contributor Author

regevbr commented Apr 19, 2020

Same goes for the build/compile script

@regevbr regevbr changed the title bug: not all packages have a test script bug: not all packages have a test/buikd script Apr 19, 2020
@regevbr regevbr changed the title bug: not all packages have a test/buikd script bug: not all packages have a test/build script Apr 22, 2020
@stale stale bot added the wontfix This will not be worked on label Jun 21, 2020
@PruvoNet PruvoNet deleted a comment from stale bot Jun 21, 2020
@stale stale bot removed the wontfix This will not be worked on label Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant