Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Nested tags that include dash symbol (ionic html) and parent name, it highlights wrong tag. #209

Open
tahaerden opened this issue Dec 27, 2019 · 2 comments

Comments

@tahaerden
Copy link

tahaerden commented Dec 27, 2019

ion highlight

I'm having this issue where a nested tag that includes dash (-) symbol includes the parent tag name in it, highlight matches faulty, as seen on screenshot.

Here is a quick example if you cannot see the screenshot above. Assume the texts wrapped with ** are getting highlighted:

**<test>**
  <test-tag>**</test-tag>**
</test>

Atom : 1.42.0
Electron: 4.2.7
Chrome : 69.0.3497.128
Node : 10.11.0

atom-lint: deprecated (maybe update it in CONTRIBUTING.md ?)
linter: 2.3.1

Whether using React editor: no

@richrace
Copy link
Member

Hmm. Using HTML for the grammar I cannot reproduce this. Any hints?

highlight

@tahaerden
Copy link
Author

Ok that's weird. I tried in both new empty file, and also in a couple of my angular/ionic html files.

I noticed when I open my angular html the issue persists. When I click on the HTML grammar on the bottom, it says Auto detect.

When I manually select HTML from the grammar list, the issue is gone. So I guess it only happens on auto-detect HTML grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants