Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch performance suggestions #687

Open
davesmith00000 opened this issue Feb 6, 2024 · 3 comments
Open

Batch performance suggestions #687

davesmith00000 opened this issue Feb 6, 2024 · 3 comments

Comments

@davesmith00000
Copy link
Member

You might get a quick and easy performance boost by making it a sealed abstract class instead of a sealed trait.
That would make the access to the private lazy val monomorphic.

So says @sjrd.

Try it. Benchmark it. Sounds like a fun task to me. :)

@davesmith00000
Copy link
Member Author

Benchmarks, before:

image

image

@davesmith00000
Copy link
Member Author

Benchmarks, after:

image

image

@davesmith00000
Copy link
Member Author

I'm calling that inconclusive. I'll have to re-run with more iterations to get more stable numbers. Notice that List is jumping about and it shouldn't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant