Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--exit-zero option #419

Closed
dolftax opened this issue Nov 4, 2018 · 5 comments
Closed

--exit-zero option #419

dolftax opened this issue Nov 4, 2018 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@dolftax
Copy link

dolftax commented Nov 4, 2018

Is your feature request related to a problem? Please describe.
Non zero exit codes breaks builds

Describe the solution you'd like
Pass --exit-zero option to always exit with 0

Describe alternatives you've considered
Nil

Additional context
Nil

@dolftax dolftax changed the title --exit zero option --exit-zero option Nov 4, 2018
@ericwb ericwb added the enhancement New feature or request label Nov 12, 2018
@stinovlas
Copy link

Can't you just use allow_failure on GitLab, allow_failures on Travis or similar option in other pipeline runners? This will produce failed job that won't break the whole build, which is IMHO much better solution, because you still get the warning in form of a failed job.

Also, if you really want zero exit code, can't you just use bandit || true?

It seems kind of pointless to me to build this feature in the bandit itself.

@bittner
Copy link
Contributor

bittner commented Mar 21, 2019

Can't you just use allow_failure on GitLab

Why would someone? If you don't use GitLab, if you don't use Travis, if you run things locally you're screwed with this solution.

I believe, it would be a good idea to align the use of CLI and configuration options with the other common tools in the Python tool chain (flake8 and Pylint, most importantly) to honor muscle memory. Both, flake8 and and Pylint, have a --exit-zero option.

@ericwb ericwb added this to the Near Future milestone May 9, 2019
@maciejstromich
Copy link
Contributor

BTW, #510

@maciejstromich
Copy link
Contributor

@ericwb this can be closed since my PR got merged.

@dolftax dolftax closed this as completed Aug 21, 2019
@dolftax
Copy link
Author

dolftax commented Aug 21, 2019

Thank you @maciejstromich

@ericwb ericwb modified the milestones: Near Future, Release 1.6.3 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants