Improve B033 (duplicate set items) #385
Conversation
- Include the repr() of the duplicate item in the error - Point the error directly at the duplicate item Fixes PyCQA#384
There was a problem hiding this comment.
LGTM - So we get an error per duplicate now right? So if the "multi_line" set had 0, False as well, we'd get two errors?
(Just confirming I'm reading it right)
I ask, cause if so that's awesome. I prefer tools that show you all the errors so you can fix them all and don't get new errors after you fix on where ever possible ...
|
Yes, we'll give errors for all of them. Could add a test showing that explicitly if you like. |
Awesome. I won't block on it, so feel free to merge, but if you have time to do so, I think it clearly states the full intention and guards against regression in the future. |
|
Easy enough to do, I pushed the new test |
Fixes #384