Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the ordering rules to __all__ #180

Closed
tlocke opened this issue Apr 3, 2021 · 2 comments
Closed

Apply the ordering rules to __all__ #180

tlocke opened this issue Apr 3, 2021 · 2 comments

Comments

@tlocke
Copy link

tlocke commented Apr 3, 2021

Hi, I'm a great fan of flake8-import-order, thanks for working on it :-). My suggestion is to apply the same ordering rules to the __all__ module attribute. Would that be a good idea?

@sigmavirus24
Copy link
Member

In #163 we discuss that this project is vaguely under a feature-freeze. I don't have opinions on whether __all__ should be ordered or not but I'm not sure it'll be implemented by this project either way

@tlocke
Copy link
Author

tlocke commented Apr 12, 2021

Okay, I'll close this issue then. Btw, I wrote https://github.com/tlocke/flake8-alphabetize to do the sorting of __all__ as well as sorting imports.

@tlocke tlocke closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants