Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not import pep8 always/unnecessarily #3

Open
sigmavirus24 opened this issue Oct 13, 2021 · 0 comments
Open

Do not import pep8 always/unnecessarily #3

sigmavirus24 opened this issue Oct 13, 2021 · 0 comments

Comments

@sigmavirus24
Copy link
Member

In GitLab by @blueyed on Jan 8, 2019, 14:07

In https://gitlab.com/pycqa/flake8-polyfill/blob/8664f8e3186ecb0dfdfa057787dc9a6f426ed32c/src/flake8_polyfill/stdin.py#L2-5 pep8 gets imported always, which might trigger https://gitlab.com/pycqa/flake8-docstrings/issues/28 (because pycodestyle's wheel itself ships pep8.py (PyCQA/pycodestyle#745)).

I think it makes sense to only try to import it on demand in general, i.e. it would not import it when only pycodestyle should get patched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sigmavirus24