-
-
Notifications
You must be signed in to change notification settings - Fork 598
Comparing changes
Open a pull request
base repository: PyCQA/isort
base: 5.8.0
head repository: PyCQA/isort
compare: 5.9.0
Commits on Mar 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for faa8293 - Browse repository at this point
Copy the full SHA faa8293View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9665722 - Browse repository at this point
Copy the full SHA 9665722View commit details
Commits on Mar 22, 2021
-
Fix bug regarding multiline docstrings
If a multiline docstring has its closing quotes at the end of a line instead of on a separate line, isort fails to properly add imports using the `add_imports` config option; instead, it adds the desired imports into the middle of the docstring as illustrated below. While PEP 257 (and other guides) advises that closing quotes appear on their own line, `isort` should not fail here. This change adds a check for closing docstrings at the end of a line in addition to the existing line start check for all comment indicators. A new section of the `test_add_imports` test explicitly tests multiline imports and this failure scenario specifically. --- A working example: ```python """My module. Provides example functionality. """ print("hello, world") ``` Running `isort --add-import "from __future__ import annotations"` produces the following as expected: ```python """My module. Provides example functionality. """ from __future__ import annotations print("hello, world") ``` --- The failure behavior described: ```python """My module. Provides example functionality.""" print("hello, world") ``` Running `isort --add-import "from __future__ import annotations"` as above produces the following result: ```python """My module. from __future__ import annotations Provides example functionality.""" print("hello, world") ``` Subsequent executions add more import lines into the docstring. This behavior occurs even if the file already has the desired imports.
Configuration menu - View commit details
-
Copy full SHA for 2ccb497 - Browse repository at this point
Copy the full SHA 2ccb497View commit details
Commits on Mar 23, 2021
-
Merge pull request #1695 from jonafato/fix-multiline-docstring-ending…
…-on-line-add_import Fix bug regarding multiline docstrings
Configuration menu - View commit details
-
Copy full SHA for f5e0447 - Browse repository at this point
Copy the full SHA f5e0447View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d3aa87 - Browse repository at this point
Copy the full SHA 5d3aa87View commit details -
Configuration menu - View commit details
-
Copy full SHA for a07bdf3 - Browse repository at this point
Copy the full SHA a07bdf3View commit details
Commits on Mar 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for dbd5a9e - Browse repository at this point
Copy the full SHA dbd5a9eView commit details
Commits on Mar 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bf715a4 - Browse repository at this point
Copy the full SHA bf715a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f01a8e0 - Browse repository at this point
Copy the full SHA f01a8e0View commit details
Commits on Mar 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ead8c7c - Browse repository at this point
Copy the full SHA ead8c7cView commit details
Commits on Apr 1, 2021
-
Merge pull request #1698 from legau/gitignorerelativefix
Fix --gitignore flag not working on relative subdir files
Configuration menu - View commit details
-
Copy full SHA for 48fe239 - Browse repository at this point
Copy the full SHA 48fe239View commit details
Commits on Apr 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3896dae - Browse repository at this point
Copy the full SHA 3896daeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27606a9 - Browse repository at this point
Copy the full SHA 27606a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a9dd4c - Browse repository at this point
Copy the full SHA 8a9dd4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07cf921 - Browse repository at this point
Copy the full SHA 07cf921View commit details
Commits on Apr 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 92a23f4 - Browse repository at this point
Copy the full SHA 92a23f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33e3623 - Browse repository at this point
Copy the full SHA 33e3623View commit details -
Configuration menu - View commit details
-
Copy full SHA for f074239 - Browse repository at this point
Copy the full SHA f074239View commit details
Commits on Apr 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 927cf7e - Browse repository at this point
Copy the full SHA 927cf7eView commit details
Commits on Apr 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4f32c44 - Browse repository at this point
Copy the full SHA 4f32c44View commit details
Commits on Apr 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9647353 - Browse repository at this point
Copy the full SHA 9647353View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5592f42 - Browse repository at this point
Copy the full SHA 5592f42View commit details -
Configuration menu - View commit details
-
Copy full SHA for fab05f2 - Browse repository at this point
Copy the full SHA fab05f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 008d0a6 - Browse repository at this point
Copy the full SHA 008d0a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5ce76f - Browse repository at this point
Copy the full SHA a5ce76fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bedc207 - Browse repository at this point
Copy the full SHA bedc207View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dff805 - Browse repository at this point
Copy the full SHA 3dff805View commit details -
Merge pull request #1706 from PyCQA/issue/1705/stream/skip-failure
Issue/1705/stream/skip failure
Configuration menu - View commit details
-
Copy full SHA for 99faae8 - Browse repository at this point
Copy the full SHA 99faae8View commit details
Commits on Apr 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 98b6019 - Browse repository at this point
Copy the full SHA 98b6019View commit details -
Configuration menu - View commit details
-
Copy full SHA for 098f714 - Browse repository at this point
Copy the full SHA 098f714View commit details
Commits on Apr 21, 2021
-
Merge pull request #1710 from RuRo/fix-userwarnings
Fix UserWarnings
Configuration menu - View commit details
-
Copy full SHA for be1e2d4 - Browse repository at this point
Copy the full SHA be1e2d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d059d60 - Browse repository at this point
Copy the full SHA d059d60View commit details -
Configuration menu - View commit details
-
Copy full SHA for bde7e70 - Browse repository at this point
Copy the full SHA bde7e70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8701c58 - Browse repository at this point
Copy the full SHA 8701c58View commit details
Commits on Apr 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 90ab857 - Browse repository at this point
Copy the full SHA 90ab857View commit details -
Configuration menu - View commit details
-
Copy full SHA for 123c97e - Browse repository at this point
Copy the full SHA 123c97eView commit details
Commits on Apr 23, 2021
-
Merge pull request #1712 from vapier/main
fix typo in stream API docs
Configuration menu - View commit details
-
Copy full SHA for 768a319 - Browse repository at this point
Copy the full SHA 768a319View commit details -
Configuration menu - View commit details
-
Copy full SHA for c617ddc - Browse repository at this point
Copy the full SHA c617ddcView commit details -
Configuration menu - View commit details
-
Copy full SHA for af97f07 - Browse repository at this point
Copy the full SHA af97f07View commit details
Commits on Apr 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2cd28e9 - Browse repository at this point
Copy the full SHA 2cd28e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78aac6e - Browse repository at this point
Copy the full SHA 78aac6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03ac140 - Browse repository at this point
Copy the full SHA 03ac140View commit details
Commits on Apr 28, 2021
-
Merge pull request #1716 from anirudnits/issue/1675/docs
Issue/1675/docs
Configuration menu - View commit details
-
Copy full SHA for 5e29571 - Browse repository at this point
Copy the full SHA 5e29571View commit details
Commits on Apr 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 337ca6b - Browse repository at this point
Copy the full SHA 337ca6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ca4261 - Browse repository at this point
Copy the full SHA 2ca4261View commit details
Commits on Apr 30, 2021
-
Merge pull request #1717 from anirudnits/issue/1714
Issue/1714 multiline tab bug
Configuration menu - View commit details
-
Copy full SHA for 2402dae - Browse repository at this point
Copy the full SHA 2402daeView commit details
Commits on May 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 60d8e2e - Browse repository at this point
Copy the full SHA 60d8e2eView commit details
Commits on May 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6efb3ac - Browse repository at this point
Copy the full SHA 6efb3acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c46082 - Browse repository at this point
Copy the full SHA 8c46082View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4e2c02 - Browse repository at this point
Copy the full SHA c4e2c02View commit details
There are no files selected for viewing