Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate-code error only shows up with pylint-jobs=1 #3314

Closed
jpsamper2009 opened this issue Dec 19, 2019 · 2 comments · Fixed by #4007
Closed

duplicate-code error only shows up with pylint-jobs=1 #3314

jpsamper2009 opened this issue Dec 19, 2019 · 2 comments · Fixed by #4007
Labels

Comments

@jpsamper2009
Copy link

Steps to reproduce

$ git clone https://gitlab.com/apexai/grge
$ cd grge
$ git checkout 98188d88df1c6b5febf9f78a8bd8f969e2d158a1
$ python3.7 -m venv venv
$ source venv/bin/activate
$ pip install -r requirements/tests.txt
$ pytest --pylint -m pylint --pylint-jobs=1
...
1 failed, 32 passed
$ rm -rf .pytest_cache
$ pytest --pylint -m pylint
...
33 passed

Current behavior

  • We get a duplicate-code error when we run pylint in a single thread, but not when running on multiple threads

Expected behavior

  • We get a duplicate-code error regardless of the number of pylint jobs

pylint --version output

$ pylint --version
pylint 2.3.1
astroid 2.2.5
Python 3.7.5 (default, Nov  1 2019, 02:16:38) 
[Clang 10.0.0 (clang-1000.11.45.5)]
@doublethefish
Copy link
Contributor

Also see #374

@Pierre-Sassoulas
Copy link
Member

Should be fixed by #4007, (that is #3458 rebased on the latest code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants