Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Boolean expressions #3407

Closed
EugeneZelenko opened this issue Feb 13, 2020 · 5 comments · Fixed by #3644
Closed

Simplify Boolean expressions #3407

EugeneZelenko opened this issue Feb 13, 2020 · 5 comments · Fixed by #3644
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors

Comments

@EugeneZelenko
Copy link

It'll be great to have check similar to Clang-tidy readability-simplify-boolean-expr, so statements like os.access(file_name, os.R_OK) is False would be suggested to be replaced with not os.access(file_name, os.R_OK).
@PCManticore PCManticore added Good first issue Friendly and approachable by new contributors Enhancement ✨ Improvement to a component labels Feb 14, 2020
@PCManticore
Copy link
Contributor

That would be nice.

@ethan-leba ethan-leba mentioned this issue May 24, 2020
Merged
4 tasks
@EugeneZelenko
Copy link
Author

Thank you for help!

@Pierre-Sassoulas
Copy link
Member

Thank you @ethan-leba :)

@ethan-leba
Copy link
Contributor

My pleasure!

@EugeneZelenko
Copy link
Author

My pleasure!

Thank you for implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New check simplifiable-condition and add bool() check for len-as-condition ethan-leba/pylint
4 participants
@PCManticore @ethan-leba @Pierre-Sassoulas @EugeneZelenko