New Check: Warning for breakpoint calls. no-breakpoint

[SalomonSmeke]

Is your feature request related to a problem? Please describe

Since python 3.7 there is a new builtin breakpoint(). Although there are environment variables you can set in production to make breakpoint() a no-op, the default behavior (unset) is to allow breakpoint(). Further, setting this flag makes it circuitous to use a breakpoint when you need one in a shell, or doing some debugging.

How often do you intentionally commit breakpoints into your packages? Projects? Production? Even in test environments its unusual.

Describe the solution you'd like

A new warning :)

Additional context

From PEP 553 re: breakpoints:

Completely disabling all accidental breakpoint() calls pushed to production. This could be accomplished by setting PYTHONBREAKPOINT=0 in the execution environment. Another suggestion by reviewers of the PEP was to set PYTHONBREAKPOINT=sys.exit in this case.

Uncertain

Should sys.breakpointhook() also be disallowed?

[SalomonSmeke]

@PCManticore do those tags mean that the idea/concept outlined in the above sound like a good plan? I started to implement this but I didn't want to get too far only to find out that the concept itself was unpalatable/misaligned to/with pylint!

Or rather is there still a discussion stage or something like that.