Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move doc build checks from travis to readthedocs PR checks #3850

Closed
graingert opened this issue Sep 19, 2020 · 5 comments · Fixed by #4298
Closed

move doc build checks from travis to readthedocs PR checks #3850

graingert opened this issue Sep 19, 2020 · 5 comments · Fixed by #4298
Assignees
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Milestone

Comments

@graingert
Copy link
Contributor

graingert commented Sep 19, 2020

Currently builds are checked with tox/travis, but the readthedocs environment is different/more restrictive than travis.

It would be better to have readthedocs build and check the docs for PRs rather than travis: https://docs.readthedocs.io/en/stable/guides/autobuild-docs-for-pull-requests.html

It's probably worth leaving the docs test in tox for local development

github readthedocs build status report animation

@hippo91
Copy link
Contributor

hippo91 commented Sep 28, 2020

@graingert i think it is a good idea. I would like to know what @Pierre-Sassoulas , @AWhetter and @PCManticore think about it.

@Pierre-Sassoulas
Copy link
Member

Sounds good to me too.

@graingert
Copy link
Contributor Author

steps that are needed:

go here: ​https://readthedocs.org/dashboard/pylint/advanced/#id_external_builds_enabled and tick this box ​image

then screenshot the "Default settings" fromset, it should look something like this: image I can use that to create a .readthedocs.yml file

then go here ​https://readthedocs.org/dashboard/pytlint/integrations/create/ to double check the webhook is enabled
image

@graingert
Copy link
Contributor Author

@Pierre-Sassoulas or I can set this up, with admin access to the pylint repo and readthedocs project

@Pierre-Sassoulas Pierre-Sassoulas self-assigned this Nov 11, 2020
@Pierre-Sassoulas
Copy link
Member

I'm a pylint-admin now, let's do this :D

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.7.5 milestone Apr 5, 2021
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Apr 5, 2021
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Apr 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow and removed task labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants