New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pylint similarities checker fails with "ignore-signatures" option enabled and function with docstring-only body #4648
Comments
Thank you for opening the issue, and for all the detail provided, it will be fixed in 2.9.3. |
@Pierre-Sassoulas thanks for the quick response. The way it was resolved in #4649 we will ignore such functions at all and signatures would be checked in similarities for them. Should we have a follow-up issue to improve it? |
Yes, I just wanted to avoid the crash in 2.9.3. Would you be interested in doing the real fix 😄 ? |
@Pierre-Sassoulas yes 🙃 Additionally, we could try to improve But possibly it could be another improvement issue. |
Sound great ! Fixing the false negative can go in 2.9, but we'll wait for |
Newly introduced
ignore-signatures
option for similarities checker fails for functions with an empty body with docstring only.Works fine if
ignore-signatures
is disabled.Steps to reproduce
Given a file
a.py
:Current behavior
Result of
pylint --disable=all --enable=similarities --ignore-signatures=yes a.py
:Expected behavior
Pylint shouldn't fail, no error appears.
pylint --version output
Result of
pylint --version
output:The text was updated successfully, but these errors were encountered: