Fix handling of -- as separator of positional arguments and flags
#7096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Reported in https://github.com/PyCQA/pylint/issues/7003. | ||
| """ | ||
| Run(["--", str(EMPTY_MODULE)], exit=False) |
There was a problem hiding this comment.
Should we test that option are taken into account for example here an init-hook that print ?
There was a problem hiding this comment.
We could, but I'm fairly confident this should work. The code that this is changing is a pylint hack on top of argparse. We parse arguments with parse_known_args so argparse doesn't complain about unknown options and leaves that to us.
I simply didn't know that this is allowed so this wasn't excluded from the list of unknown options. argparse probably does dit automatically in the normale parse_args.
Pierre-Sassoulas
approved these changes
Jun 30, 2022
DanielNoord
added
the
Needs backport
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 09e7027 |
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
Closes #7003.