You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GithubRetry's default values for status_forcelist and allowed_methods are computed in __init__. See here. We had a use case where we wanted extend (not override) the default values, but we resorted to copy-pasting. It would be better to have class members for it, similar to Retry.DEFAULT_ALLOWED_METHODS.
Instead of:
GithubRetry(
# GithubRetry default value + 401status_forcelist=list(range(500, 600)) + [403, 401],
# GithubRetry default value + "PATCH". # GithubRetry.DEFAULT_ALLOWED_METHODS currently inherited from urllib3.Retryallowed_methods=GithubRetry.DEFAULT_ALLOWED_METHODS.union(
{"GET", "POST", "PATCH"}
),
)
GithubRetry
's default values forstatus_forcelist
andallowed_methods
are computed in__init__
. See here. We had a use case where we wanted extend (not override) the default values, but we resorted to copy-pasting. It would be better to have class members for it, similar toRetry.DEFAULT_ALLOWED_METHODS
.Instead of:
it would be better to have:
The text was updated successfully, but these errors were encountered: