Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove n.lopf() for pyomo and nomopyomo + HiGHS default solver #884

Merged
merged 7 commits into from
May 15, 2024
Merged

Remove n.lopf() for pyomo and nomopyomo + HiGHS default solver #884

merged 7 commits into from
May 15, 2024

Conversation

fneum
Copy link
Member

@fneum fneum commented May 12, 2024 •
edited

Closes #698
Closes #875
Closes #691
Closes #838
Closes #823
Closes #448
Closes #438
Closes #373

Changes proposed in this Pull Request

  • Removes pyomo-based and nomopyomo-based optimisation modules called through n.lopf. Only linopy optimisation module is kept.
  • Make HiGHS default solver.
  • Deprecate pypsa/optimization/compat.py

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@fneum fneum mentioned this pull request May 12, 2024
Open
12 tasks
@codecov Codecov
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (467db67) to head (bc9a2a8).
Report is 69 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #884       +/-   ##
===========================================
+ Coverage   66.30%   80.66%   +14.36%     
===========================================
  Files          26       22        -4     
  Lines        7090     4619     -2471     
  Branches     1425      946      -479     
===========================================
- Hits         4701     3726      -975     
+ Misses       2105      663     -1442     
+ Partials      284      230       -54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fneum
Copy link
Member Author

fneum commented May 15, 2024

do you agree @FabianHofmann ?

@FabianHofmann
Copy link
Collaborator

Frühjahrsputz! Let's do it :)

@fneum fneum merged commit 21f8d20 into master May 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fneum @FabianHofmann