Save shadow price for CO2Limit global constraint as positive #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p/PyPSA into positive-co2-shadow-price
for more information, see https://pre-commit.ci
|
@martavp I don't know if that is the right spot. people might name their constraints differently, "co2_limit", "co2limit", "co2-constraints' .... |
|
Thanks for the suggestion @FabianHofmann I know the solution is a bit hacky but at least self-explanatory. Would you suggest modifying the network in PyPSA-Eur after the optimize function was run? Wouldn't potential people using different names for their co2Limite-related constraint also expect to get a positive value for the dual? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #843
Changes proposed in this Pull Request
The dual of the CO2Limit global constraint was saved as negative due to the co2_emissions defined as -1. This PR forces the shadow CO2 price to be saved as a positive number.
Checklist
doc.environment.yaml,environment_docs.yamlandsetup.py(if applicable).doc/release_notes.rstof the upcoming release is included.