Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleNotFoundError when calling crfcut engine in sent_tokenize function #859

Open
pavaris-pm opened this issue Nov 7, 2023 · 2 comments
Labels
question asking questions/giving suggestions

Comments

@pavaris-pm
Copy link
Contributor

i've try the crfcut engine in sent_tokenize function in stable release version of PyThaiNLP via

pip install --upgrade pythainlp

this is what i expected

sent_tokenize(sentence_1, engine="crfcut")
# output: ['ฉันไปประชุมเมื่อวันที่ 11 มีนาคม']

however, i got this as an output instead

sent_tokenize(sentence_1, engine="crfcut")

# ModuleNotFoundError: No module named 'pycrfsuite'

since it is a missing package problem, it can be solved by pip install python-crfsuite in order to make it compatible to be used. However, is it better to fix it so that the user has no need to take an extra step to install crfsuite everytime they want to use an engine, or we can just leave it as usual here. What do you think ?

@wannaphong
Copy link
Member

python-crfsuite is often python problem when python was released new version. You can see #655. We doesn't add python-crfsuite to the dependencies list.

@wannaphong
Copy link
Member

I looking new model to removed all crfsuite model but these models are quite efficient and therefore not worth replacing. Deep learning model are not much better.

@wannaphong wannaphong added the question asking questions/giving suggestions label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question asking questions/giving suggestions
Projects
None yet
Development

No branches or pull requests

2 participants