Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias TreeProcessor to Treeprocessor #815

Open
Celelibi opened this issue Apr 12, 2019 · 1 comment
Open

alias TreeProcessor to Treeprocessor #815

Celelibi opened this issue Apr 12, 2019 · 1 comment
Labels
someday-maybe Approved low priority request.

Comments

@Celelibi
Copy link

In the interest of consistency with BlockProcessor and most other *Processor. I suggest to provide an alias TreeProcessor to the class Treeprocessor.

This would reduce the friction for extension writers. At least a bit.

@waylan waylan added the someday-maybe Approved low priority request. label Jun 13, 2019
@waylan
Copy link
Member

waylan commented Jun 13, 2019

The Contributing Guidelines are relevant here:

Legacy code which does not follow the guidelines should only be updated if and when other changes (bug fix, feature addition, etc.) are being made to that section of code. While new features should be given names that follow modern Python naming conventions, existing names should be preserved to avoid backward incompatible changes.

I realize an alias avoids the backward compatibility issue, but personally I'm meh on the whole thing. Of course a PR is always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
someday-maybe Approved low priority request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants