Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Treeprocessor to TreeProcessor and create an alias for backwar… #1288

Closed
wants to merge 2 commits into from

Conversation

venthur
Copy link
Contributor

@venthur venthur commented Aug 28, 2022

…ds compatibility.

Closes: #815

@venthur
Copy link
Contributor Author

venthur commented Aug 28, 2022

Not sure which of the other classes matching *TreeProcessor need an alias too, just let me know, and I'll update accordingly.

@waylan
Copy link
Member

waylan commented Aug 29, 2022

I'm inclined to not merge this as the current capitalization matches the other classes (preprocessor, postprocessor, etc.). Anyone else have any thoughts?

@waylan waylan added the needs-decision A decision needs to be made regarding request. label Aug 29, 2022
@facelessuser
Copy link
Collaborator

FYI, BlockProcessor is an outlier: https://github.com/Python-Markdown/markdown/blob/master/markdown/blockprocessors.py#L59. I'm not sure which way you'd like to normalize class names 🤷🏻.

@waylan
Copy link
Member

waylan commented Aug 29, 2022

So it would appear that for the least amount of change we would change BlockProcessor => Blockprocessor, which would result in a consist style.

If we went the other way, we would need to change everything except BlockProcessor. Although, I can see an argument for not camel casing Preprocessor as that would be a single work in normal English prose. I suspect that is where the current style of not camel casing any of them case from. BlockProcessor was certainly a later addition and perhaps we forgot about that earlier style choice.

@venthur
Copy link
Contributor Author

venthur commented Aug 30, 2022

I'm fine either way, I've now also created #1290 that changes spelling for the BlockProcessor to Blockprocessor

@waylan waylan added rejected The pull request is rejected for the stated reasons. and removed needs-decision A decision needs to be made regarding request. labels Apr 18, 2023
@waylan waylan closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rejected The pull request is rejected for the stated reasons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alias TreeProcessor to Treeprocessor
3 participants