From 4fceb8476c99f7f29fbc5519947f13d9e5bf4da3 Mon Sep 17 00:00:00 2001 From: Ikko Hamamura Date: Thu, 28 Jul 2022 23:29:48 +0900 Subject: [PATCH] Improve the performance of assemble when parameter_binds is a list of empty dicts (#8407) * Fix the condition * Update qiskit/compiler/assembler.py * fix lint Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --- qiskit/compiler/assembler.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/qiskit/compiler/assembler.py b/qiskit/compiler/assembler.py index 9dc53b30e21..d7905ad0262 100644 --- a/qiskit/compiler/assembler.py +++ b/qiskit/compiler/assembler.py @@ -16,19 +16,18 @@ import uuid import warnings from time import time -from typing import Union, List, Dict, Optional +from typing import Dict, List, Optional, Union import numpy as np from qiskit.assembler import assemble_circuits, assemble_schedules from qiskit.assembler.run_config import RunConfig -from qiskit.circuit import QuantumCircuit, Qubit, Parameter +from qiskit.circuit import Parameter, QuantumCircuit, Qubit from qiskit.exceptions import QiskitError from qiskit.providers.backend import Backend -from qiskit.pulse import LoConfig, Instruction -from qiskit.pulse import Schedule, ScheduleBlock +from qiskit.pulse import Instruction, LoConfig, Schedule, ScheduleBlock from qiskit.pulse.channels import PulseChannel -from qiskit.qobj import QobjHeader, Qobj +from qiskit.qobj import Qobj, QobjHeader from qiskit.qobj.utils import MeasLevel, MeasReturnType logger = logging.getLogger(__name__) @@ -569,7 +568,7 @@ def _expand_parameters(circuits, run_config): """ parameter_binds = run_config.parameter_binds - if parameter_binds or any(circuit.parameters for circuit in circuits): + if parameter_binds and any(parameter_binds) or any(circuit.parameters for circuit in circuits): # Unroll params here in order to handle ParamVects all_bind_parameters = [