Identity transformation

[morrijr]

Hi,

I started using your library to convert from an undefined source to hsv. Without thinking I ended up coding a colorConvert.hsv.hsv conversion, which obviously doesn't exist. Would it be possible/reasonable to add a a no-op or identity transformation (ie output = input) when source and destination during the route construction?

At the moment I've trapped it an dealt with it specially, but it would be really nice not to have to have different code in the transformation path :)

Thoughts?

[Qix-]

Feel free to PR :)

[morrijr]

Hi,

I forked the project and made a stab at the changes (fork) but I've two failing tests... lines 118 and 120 in test/basic.js.

assert.deepStrictEqual(convert.ansi16.ansi16(103), 103);
assert.deepStrictEqual(convert.ansi256.ansi256(175), 175);

But I'm afraid my javascript isn't yet up to diagnosing why. Would you have a little time to take a look (no rush!). I wouldn't be comfortable doing a PR without the tests.

Thanks,
J.

[Qix-]

Feel free to open a PR and I can take a look, even if the tests are failing :)

[morrijr]

PR #66 created (failing tests commented out for now).

I'll close this issue and we can continue on the PR?

[Qix-]

Nah we'll leave this open until it's done :)

[morrijr]

's been a while, anything I can do to progress this?