Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the destruction of glitched wood fences #2027

Merged

Conversation

QuentinGruber
Copy link
Owner

@QuentinGruber QuentinGruber commented Mar 14, 2024


Generated summary (powered by Graphite)

TL;DR

This pull request introduces a temporary hack to prevent certain models from being destroyed by setting their maximum health to the maximum value of a 32-bit unsigned integer.

What changed

The maximum health for the following models: FENCES_WOOD_PLANKS_GREY_1X1, FENCES_WOOD_PLANKS_GREY_POSTS_1X2, and FENCES_WOOD_PLANKS_GREY_GAP_1X1 has been changed from 7500 to MAX_UINT32 (the maximum value of a 32-bit unsigned integer). This change effectively makes these models indestructible, unless you really want to destroy them.

How to test

To test this change, you can try to destroy the aforementioned models in the game. You should find that they are now indestructible.

Why make this change

This change was made as a temporary solution to prevent these models from being destroyed. This could be useful in scenarios where these models are used as part of the game's infrastructure and should not be destructible by players.

@github-actions github-actions bot added the client-2016 About the 2016 client label Mar 14, 2024
@QuentinGruber QuentinGruber added this to the v0.35.0 milestone Mar 14, 2024
@QuentinGruber QuentinGruber linked an issue Mar 14, 2024 that may be closed by this pull request
Copy link
Owner Author

QuentinGruber commented Mar 14, 2024

Merge activity

@QuentinGruber QuentinGruber force-pushed the 03-13-Adapt_effectId_for_new_destroyables branch from 2398dbf to d986b73 Compare March 14, 2024 17:40
@QuentinGruber QuentinGruber changed the base branch from 03-13-Adapt_effectId_for_new_destroyables to dev March 14, 2024 17:43
@QuentinGruber QuentinGruber force-pushed the 03-14-Disable_the_destruction_of_glitched_wood_fences branch from 24f2078 to 1ece516 Compare March 14, 2024 17:45
@QuentinGruber QuentinGruber merged commit a1ef660 into dev Mar 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-2016 About the 2016 client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroyed fence terrain rendering issue
1 participant