Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers don't respawn loot inside of them overtime #1932

Closed
Nikolassparrow opened this issue Feb 14, 2024 · 0 comments
Closed

Containers don't respawn loot inside of them overtime #1932

Nikolassparrow opened this issue Feb 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Nikolassparrow
Copy link
Contributor

Nikolassparrow commented Feb 14, 2024

Describe the bug
Was a bug caught by Avcio and I while talking about loot tables. Essentially, normal world spawns on H1EMU will spawn items over each pass-through in lootSpawning. This happens because on the call to spawn world loot, the function takes in all the positions of every possible spawn in the world, and whatever chance that item gets to spawn, will spawn in any available position based upon the previous spawns.

For example: lets say there's a room with 5 spawns, and 2/5 spots are taken on the 1st call. On the 2nd call, perhaps another spot is taken for 3/5. Keep repeating this process for the amount of positions in a given area.

TLDR: Normal world spawns happen overtime because vacant spots from the previous respawn are filled in.

To Reproduce
Revert #1907, load onto a world, find any container and observe overtime the amount of items that fill up that specific container.

Expected behavior
There should be few items that spawn in containers initially, but overtime fill up as time goes by until it reaches the maxItems inside of said container.

Screenshots
https://streamable.com/8gayr4

Additional context
#1907 will probably need to be reverted, and #1930 to be adjusted based upon this issue

@Nikolassparrow Nikolassparrow added the bug Something isn't working label Feb 14, 2024
@QuentinGruber QuentinGruber modified the milestone: v0.33.0 Feb 15, 2024
@QuentinGruber QuentinGruber added this to the v0.36.0 milestone Mar 13, 2024
@QuentinGruber QuentinGruber removed this from the v0.36.0 milestone Apr 30, 2024
@Z1Meme Z1Meme closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants