Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues when generated empty files #78

Open
DavidBabel opened this issue Jul 22, 2019 · 3 comments
Open

Issues when generated empty files #78

DavidBabel opened this issue Jul 22, 2019 · 3 comments

Comments

@DavidBabel
Copy link

DavidBabel commented Jul 22, 2019 •
edited

Typescript seems to complain with empty file. For example with a css file which only contains global declarations.

It may be great to just add a /* empty */ comment to prevent errors in rollup builds (for example) :
image

Thanks ! Your plugin is amazing !
@mohsen1
Copy link

mohsen1 commented Jul 22, 2019

an export {} can fix this

@DavidBabel
Copy link
Author

typescript > 2.6 disallow that.
There is an issue about that in this repo

@tgelu
Copy link

tgelu commented Jul 21, 2021

@DavidBabel are you sure it's not export default {} that is not allowed in TS > 2.6? export {} seems acceptable.

@tgelu tgelu mentioned this issue Jul 21, 2021
Merged
Quramy added a commit that referenced this issue Oct 12, 2023
@Quramy
Merge pull request #142 from tgelu/fix/78-empty-ts-files
19a1d9d 
#78 fix: empty .d.ts files are now valid TS modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mohsen1 @tgelu @DavidBabel