Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] Enhanced Error Overlay [DX] #2710

Closed
zanettin opened this issue Jan 24, 2023 · 2 comments · Fixed by #2818
Closed

[✨] Enhanced Error Overlay [DX] #2710

zanettin opened this issue Jan 24, 2023 · 2 comments · Fixed by #2818
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request

Comments

@zanettin
Copy link
Collaborator

Is your feature request related to a problem?

Enhance the current error overlay to increase DX

Describe the solution you'd like

Astro v2 just launched a new error overlay which provides additional informationen and a cleaner overview. To implement a custom overlay we would need to "opt-out" of the vite provided web component (vite-error-overlay) and create a custom solution.

things we could included if we want to implement this:

  • qwikified look and feel (use qwik colors, fonts ,etc)
  • show more lines of code in the trace
  • highlight the row that contains the error
  • reference the docs for certain issues
  • "open in editor" link instead of the current file path link

Describe alternatives you've considered

Keep the existing one and lower the maintenance work 😄

Additional context

No response

@zanettin zanettin added TYPE: enhancement New feature or request STATUS-1: needs triage New issue which needs to be triaged labels Jan 24, 2023
@manucorporat
Copy link
Contributor

Imo the error overlay is pretty good, astro 2 is a nice CSS, but the heavy work is in improving the error itself, not the overlay.

Vite overlay can be styled!
vitejs/vite#10234
PR welcome!

@zanettin
Copy link
Collaborator Author

zanettin commented Jan 26, 2023

@manucorporat still WIP and guess i'd need more exposures from the vite side, but do you have already some feedback? and sry i am not a designer 🤣

Current State

Bildschirmfoto 2023-01-26 um 23 51 37

WIP State

  • v1
    Bildschirmfoto 2023-01-26 um 23 50 02
  • v2
    Bildschirmfoto 2023-01-27 um 22 43 07

things to adjust

Info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants