Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] ServerRequestEvent needs httpVersion entry to solve HTTP/2 specific problems. #2862

Open
genki opened this issue Feb 7, 2023 · 1 comment
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request

Comments

@genki
Copy link
Contributor

genki commented Feb 7, 2023

Is your feature request related to a problem?

When using dev-server as https, currently it warns like this:

(node:79236) UnsupportedWarning: Status message is not supported by HTTP/2 (RFC7540 8.1.2.4)
(Use `node --trace-warnings ...` to show where the warning was created)

This is happening because the server response body contains status message that is not allowed for HTTP/2 protocol.
So then it is necessary to provide the body conditional to the protocol version, but there is no informations about it in the ServerRequestEvent.

Describe the solution you'd like

My suggestion is add httpVersion: {major:number, minor:number} to the ServerRequestEvent interface.
That can be acquired from IncomingMessage.

Describe alternatives you've considered

Sorry, I couldn't come up with other solution.

Additional context

No response

@genki genki added TYPE: enhancement New feature or request STATUS-1: needs triage New issue which needs to be triaged labels Feb 7, 2023
@genki genki closed this as completed Feb 14, 2023
@genki
Copy link
Contributor Author

genki commented Jul 1, 2023

I have found this issue is still happening.
So I traced warning, the reason of the problem is found in the finalhandler.
I have sent a PR to fix it.
pillarjs/finalhandler#45

@genki genki reopened this Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant