Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link is broken [馃摉] #6329

Closed
greatgraphicdesign opened this issue May 17, 2024 · 6 comments 路 Fixed by #6334
Closed

Link is broken [馃摉] #6329

greatgraphicdesign opened this issue May 17, 2024 · 6 comments 路 Fixed by #6334
Labels
COMP: docs Improvements or additions to documentation

Comments

@greatgraphicdesign
Copy link
Contributor

Suggestion

On this page, the link in the following block of text leads to a 404.

The following is an SSR portal implementation using Qwik City. If you are using multiple frontend frameworks alongside Qwik, you may prefer a [React-like portal implementation](https://github.com/qwikifiers/qwik-ui/blob/main/packages/kit-headless/src/components/popover/popover-impl.tsx#L42).
@greatgraphicdesign greatgraphicdesign added COMP: docs Improvements or additions to documentation STATUS-1: needs triage New issue which needs to be triaged labels May 17, 2024
@PatrickJS
Copy link
Member

@greatgraphicdesign can you make a pr? you can edit the file directly in github to make the pr

@maiieul maiieul removed the STATUS-1: needs triage New issue which needs to be triaged label May 17, 2024
@greatgraphicdesign
Copy link
Contributor Author

I would be happy to if I knew the correct destination, but I don鈥檛!

@PatrickJS
Copy link
Member

@thejackshelton whats the correct link?

@thejackshelton
Copy link
Member

@thejackshelton whats the correct link?

https://github.com/qwikifiers/qwik-ui/blob/main/packages/kit-headless/src/components/popover/popover-panel-impl.tsx#L84

recently changed the name sorry about that.

@thejackshelton
Copy link
Member

@greatgraphicdesign up for making a PR with the link above?

@greatgraphicdesign
Copy link
Contributor Author

Submitted: #6334

@PatrickJS PatrickJS mentioned this issue May 18, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fixes broken link greatgraphicdesign/qwik
4 participants
@PatrickJS @greatgraphicdesign @maiieul @thejackshelton