Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK-17: implement ESLint #52

Closed
RGPosadas opened this issue Mar 15, 2020 · 1 comment
Closed

TASK-17: implement ESLint #52

RGPosadas opened this issue Mar 15, 2020 · 1 comment
Assignees
@JimLau49 @leojrsilao
Labels
task
Milestone
SPRINT #3

Comments

@RGPosadas
Copy link
Owner

RGPosadas commented Mar 15, 2020 •
edited

As a developer, I want to implement ESLint so that it enforces coding standards and practices.

We currently do not have any JS/TS linters on our pre-commit. To keep on enabling good practices, we need to install ESLint: https://eslint.org/docs/user-guide/getting-started

ACCEPTANCE CRITERIA:

  • Our JS/TypeScript code is linted
  • Linters run on Travis as well
  • There exists a section in the README on how to run ESLint
@RGPosadas RGPosadas added the task label Mar 15, 2020
@RGPosadas RGPosadas added this to the SPRINT #3 milestone Mar 15, 2020
@RGPosadas RGPosadas changed the title TASK-17: implement ESLintt TASK-17: implement ESLint Mar 18, 2020
@JimLau49 JimLau49 self-assigned this Mar 18, 2020
@leojrsilao leojrsilao self-assigned this Mar 18, 2020
JimLau49 added a commit that referenced this issue Mar 18, 2020
@JimLau49
ESLint pre-commit hooks #52
09d0148
@JimLau49
Copy link
Collaborator

JimLau49 commented Mar 18, 2020 •
edited

Running into an issue
image

eslint/eslint#12707

JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Added ESLint config and deployed to Travis #52
0ce2ad3
@JimLau49 JimLau49 mentioned this issue Mar 21, 2020
Closed
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Added ESLint and deployed on Travis, fixed revert #52
d1f65c2
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Fixed Revert and ESLint deployed on Travis #52
b854c67
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Added ESLint and deployed on Travis, fixed revert #52
cb7cb8f
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Added ESLint and deployed on Travis, fixed revert #52
6f343a3
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Added ESLint and deployed on Travis, fixed revert #52
c875ac3
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Added ESLint and deployed on Travis, fixed revert #52
3f4e357
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Added ESLint and deployed on Travis, fixed revert #52
a939946
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
modified README.md #52
3433237
@JimLau49 JimLau49 mentioned this issue Mar 21, 2020
Merged
JimLau49 added a commit that referenced this issue Mar 21, 2020
@JimLau49
Modified ESLint #52
501bac2
cindyslittleplanet pushed a commit that referenced this issue Mar 24, 2020
@JimLau49 @cindyslittleplanet
Added ESLint and deployed on Travis, fixed revert #52
8b2802b
cindyslittleplanet pushed a commit that referenced this issue Mar 24, 2020
@JimLau49 @cindyslittleplanet
modified README.md #52
c7c5679
cindyslittleplanet pushed a commit that referenced this issue Mar 24, 2020
@JimLau49 @cindyslittleplanet
Modified ESLint #52
55b4ac4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimLau49 JimLau49

@leojrsilao leojrsilao

Labels
task
Projects
None yet
Milestone
SPRINT #3
Development

No branches or pull requests
3 participants
@RGPosadas @JimLau49 @leojrsilao