-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/abp2: add abp2 driver #20398
base: master
Are you sure you want to change the base?
Conversation
1a59f06
to
fcb2d07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, that's a nice first driver!
Some comments:
e2c4682
to
cba1b60
Compare
549c360
to
5230483
Compare
your commits messages will need rewording https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions |
Could you be more accurate ? |
5230483
to
0e61666
Compare
so you commit messages should be for example driver/abp2: driver for SPI sensors prepare for I2C tests/driver/abp2: test implementation or something similar the scheme is |
a1639ea
to
0b5b176
Compare
0b5b176
to
df8c901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from the leftover in the test app this seems good to go
please provide current test results from the current version starting at shell prompt
(I don't have the hardware to test)
That's good news!
What do you mean? What about the program output in the 1st message of this thread? |
df8c901
to
3126c7d
Compare
i see you updated it ( 1h ago there where non english words in it ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some static tests ci style things
3126c7d
to
e4d52c4
Compare
Honeywell ABP2 pressure sensors series. Implement all sensors features, only supporting the SPI version of the sensor. Prepare future support for the I2C interface by emphasizing where to implement the code that will support the I2C bus version.
Use pseudomodules to add a dependency on the relevant feature: periph_spi if the abp2_spi pseudomodule is selected, or periph_i2c if the abp2_i2c pseudomodule is selected.
e4d52c4
to
e01e24f
Compare
|
Should I apply these changes and force push? Also, I noticed that entries in this file are sorted. So these lines should be added further up in the file. |
yes (problem noticed by murdock)
please add the lines where they belong - good you noticed |
e01e24f
to
b7198cc
Compare
btw are you also working towards i2c support? |
I have no plan to do so because I don't have a I2C version at hand. |
Contribution description
Testing procedure
Use the test application in
RIOT/tests/drivers/abp2
.Output of the test application:
Issues/PRs references
Fixes #20233