Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: indication of test run started and finished #193

Open
gregveres opened this issue May 15, 2020 · 0 comments
Open

FR: indication of test run started and finished #193

gregveres opened this issue May 15, 2020 · 0 comments

Comments

@gregveres
Copy link
Contributor

Is this a bug report or a feature request?

Feature request

Version Info

  • Version of Majestic: 1.7.0
  • Version of Jest:
  • Version of Node:
  • Operating System:

Reproduction Repo

I am using watch mode for a single file. When I save the file in question, jest kicks off a test run and when the test run is done, jest gets the results. All the while, the hashed background on the test-file/summary is animated to indicate that jest is still running. And the run becomes a "stop" when jest is running.

It would be nicer if the following happened for certain events

  • pressing run:
    • the button should change to stop
    • the background of the summary should animate because jest is doing the initial run
  • jest is doing the initial run
    • the button is stop
    • the background is animated
  • completes the initial run
    • the button is still stop
    • the background stops animating
  • I save the test file and jest starts running the tests
    • the button is still stop
    • the background starts animating
  • jest finishes running the tests
    • the button is still stop
    • the background stops animating
  • I press stop
    • the button returns to run

This allows the user to understand what state jest is in.
Jest is idle watch mode when the button says stop
jest is actively running tests when the background is animated

If the UI behaved this way, I would be able to look at the screen and know exactly what state I am in and if I should wait longer before trusting the state of the test results.
gregveres pushed a commit to gregveres/majestic that referenced this issue May 15, 2020
changed summary to only animate when updating
0eb6429 
When in watch mode, the summary background used to animate all
the time. This meant that it was difficult to understand if the test was
currently running or if the results you were looking at were the result
of the latest test run.

With this change the background only animates when a test is actually
in progress. If you are in watch mode, the play button turns to a stop
button and the background is not animated, But when Jest is running,
the background is animating. When jest finishes, the background stops.

This addresses issue Raathigesh#193
gregveres pushed a commit to gregveres/majestic that referenced this issue May 15, 2020
changed summary to only animate when updating
2abc1e0 
When in watch mode, the summary background used to animate all
the time. This meant that it was difficult to understand if the test was
currently running or if the results you were looking at were the result
of the latest test run.

With this change the background only animates when a test is actually
in progress. If you are in watch mode, the play button turns to a stop
button and the background is not animated, But when Jest is running,
the background is animating. When jest finishes, the background stops.

This addresses issue Raathigesh#193
@gregveres gregveres mentioned this issue May 15, 2020
Merged
Raathigesh pushed a commit that referenced this issue May 18, 2020
@gregveres
193 better indication test run status (#198)
c7ad094 
* changed summary to only animate when updating

When in watch mode, the summary background used to animate all
the time. This meant that it was difficult to understand if the test was
currently running or if the results you were looking at were the result
of the latest test run.

With this change the background only animates when a test is actually
in progress. If you are in watch mode, the play button turns to a stop
button and the background is not animated, But when Jest is running,
the background is animating. When jest finishes, the background stops.

This addresses issue #193

* fixed merge error

cherry picking the commit brought in part of another change.
this undoes that other change and puts the removed code back.

Co-authored-by: Greg Veres <greg.veres@rogers.com>
@gregveres gregveres mentioned this issue May 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregveres