Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: provide a collapse all and expand all button for the file tree #203

Open
gregveres opened this issue May 19, 2020 · 0 comments
Open

Comments

@gregveres
Copy link
Contributor

Is this a bug report or a feature request?

I would like to see a collapse all and an expand all button for the file tree in the right panel. I have a lot of tests in a lot of subdirectories. The easiest way to find the one I am working on is to navigate the file tree. However, the file tree is too big to work with when it is fully expanded (which it is by default).

I would like to see two buttons on the tree: collapse all and expand all.
The collapse all would collapse all the directory nodes in the tree except the top level node
the expand all would expand all the directory nodes in the tree.

Version Info

  • Version of Majestic: v1.7.0
  • Version of Jest: 25
  • Version of Node:
  • Operating System:

Reproduction Repo

Load up a test directory with thousands of tests. Now try to find the test file you want. it is difficult with a fully expanded tree. It becomes much easier when the tree starts collapsed or there is a mechanism to collapse the tree.

gregveres pushed a commit to gregveres/majestic that referenced this issue May 19, 2020
I have added two icons to the tree control icon area. The first collapses
all the directories in the tree except the root directory and the other
expands all the directories in the tree.

This makes it much easier to find a test file to work on.
I also put the icons on the right side because that is where the
"show failing tests only" icon appears and it seemed that they were
similar types of operations. Then I realized that the collapse / expand
don't make sense when the show failing test only icon is toggled
so in that case I hide the icons.

And then because the icons vanish and appear, I rearranged their
position to what I thought made more sense.
Refresh: is always present and always in a fixed location on the right
The most important button is show only failed so it shows up on the
left as the first in the list when there are failed tests.
Then the collapse/expand
Then the coverage (which I think is the least likely to be used) and
therefore in the "hardest spot to hit"
Raathigesh#203
@gregveres gregveres changed the title PR: provide a collapse all and expand all button for the file tree FR: provide a collapse all and expand all button for the file tree May 19, 2020
Raathigesh pushed a commit that referenced this issue May 20, 2020
I have added two icons to the tree control icon area. The first collapses
all the directories in the tree except the root directory and the other
expands all the directories in the tree.

This makes it much easier to find a test file to work on.
I also put the icons on the right side because that is where the
"show failing tests only" icon appears and it seemed that they were
similar types of operations. Then I realized that the collapse / expand
don't make sense when the show failing test only icon is toggled
so in that case I hide the icons.

And then because the icons vanish and appear, I rearranged their
position to what I thought made more sense.
Refresh: is always present and always in a fixed location on the right
The most important button is show only failed so it shows up on the
left as the first in the list when there are failed tests.
Then the collapse/expand
Then the coverage (which I think is the least likely to be used) and
therefore in the "hardest spot to hit"
#203

Co-authored-by: Greg Veres <greg.veres@rogers.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant