Throw download as failed for invalid magnet links

mynameisbogdan · mynameisbogdan · commit 7edb892eb443 · 2024-01-17T00:07:04.000+02:00
(cherry picked from commit 091449d9bff9023ca27a85cc1048296f7d5ea37b) Closes #9625 Fixes #9125
diff --git a/src/NzbDrone.Core/Download/TorrentClientBase.cs b/src/NzbDrone.Core/Download/TorrentClientBase.cs
@@ -223,9 +223,7 @@ private string DownloadFromMagnetUrl(RemoteMovie remoteMovie, IIndexer indexer,
             }
             catch (FormatException ex)
             {
-                _logger.Error(ex, "Failed to parse magnetlink for movie '{0}': '{1}'", remoteMovie.Release.Title, magnetUrl);
-
-                return null;
+                throw new ReleaseDownloadException(remoteMovie.Release, "Failed to parse magnetlink for episode '{0}': '{1}'", ex, remoteMovie.Release.Title, magnetUrl);
             }
 
             if (hash != null)

Original file line number	Diff line number	Diff line change
`@@ -223,9 +223,7 @@ private string DownloadFromMagnetUrl(RemoteMovie remoteMovie, IIndexer indexer,`
`223`	`223`	`}`
`224`	`224`	`catch (FormatException ex)`
`225`	`225`	`{`
`226`		`- _logger.Error(ex, "Failed to parse magnetlink for movie '{0}': '{1}'", remoteMovie.Release.Title, magnetUrl);`
`227`		`-`
`228`		`- return null;`
	`226`	`+ throw new ReleaseDownloadException(remoteMovie.Release, "Failed to parse magnetlink for episode '{0}': '{1}'", ex, remoteMovie.Release.Title, magnetUrl);`
`229`	`227`	`}`
`230`	`228`
`231`	`229`	`if (hash != null)`